Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new mongo driver v4 #8

Merged
merged 1 commit into from Feb 15, 2022
Merged

Conversation

renanccastro
Copy link

@renanccastro renanccastro commented Jan 25, 2022

Hello!
On Meteor 2.6 we are introducing support for the new node.js mongo driver, v4.x, and the aggregate function doesn't require a callback anymore, only the toArray function does.

@renanccastro renanccastro mentioned this pull request Jan 25, 2022
8 tasks
@edwardupton
Copy link

+1 to merge this in

@dokithonon
Copy link

+1 for me too. Please merge it.

@RomainSennat
Copy link

Same for me.

@sakulstra sakulstra merged commit 2aff53b into sakulstra:master Feb 15, 2022
@sakulstra
Copy link
Owner

Hay, is anyone up to taking over this package? @renanccastro , @edwardupton, @dokithonon, @RomainSennat
It's not that hard to maintain, but I've left the meteor ecosystem at least 3 years ago 😅
Wasn't there some effort to create a community org or sth similar to move this pacakges to? I can't remember.

@sakulstra
Copy link
Owner

sorry no idea how to publish this any more... managed to recover my password & install meteor, but seems like there's issues with the package.js and i have no idea how to resolve them (first Unknown release METEOR@1, changed that to a more up to date version, just to have errors with accounts-password version) ... if someone manages to create a pr with a package.js that allowed me releasing this i'm happy to do so. If not please go ahead and fork the repo.

@renanccastro
Copy link
Author

hi @sakulstra, thanks for chiming in.

That's fine. if you are willing to transfer the package ownership, we as Meteor Software can take it.

I will publish the new version in your namespace. Thanks for your work here!

@renanccastro
Copy link
Author

The new repo will be forked under Meteor Compat organization.

@sakulstra
Copy link
Owner

@renanccastro sounds good to me 🎉 let me know if/where i have to do sth to give you ownership of my handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants