-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery style is lost when the page is reloaded #2
Comments
Thanks a lot for opening this issue. I didn't run into the problem, as I had page caching disabled. Good catch! Seems like the problem is known: https://discourse.getgrav.org/t/plugins-and-caching/6795/9 I will see what I can do to remedy this situation. |
Fixed in c743188. Please verify the fix and close this issue, if it worked. |
Did you find some time to test the updated version, @beamaria ? 😗 |
Sorry, the issue is still there; if you don't disable the cache, the pictures are stacked... |
Mh, which version of the plugin do you use? |
Version 1.0.3 with Grav 1.7.7
I found the way to replicate the issue: In advanced tab of the page put the tick beside caching and enable it: this way the images are stacked on reloading.
If you don't have the tick, the issue is gone.
(see attachments)
Issue
<img width="873" alt="issue" src="https://user-images.githubusercontent.com/11693902/109132172-70950900-774b-11eb-9dd6-6b65c22e6ecd.png">
NO issue--> OK
<img width="873" alt="NO issue" src="https://user-images.githubusercontent.com/11693902/109132199-7a1e7100-774b-11eb-969f-ebe951562c05.png">
… Il giorno 24 feb 2021, alle ore 19:57, sal0max ***@***.***> ha scritto:
Mh, which version of the plugin do you use?
I can't replicate the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACZG6TSZSEP7FXLNUMGBKVTTAVK2NANCNFSM4XIYZI3Q>.
|
Alright, that helps. :) There are two Cache settings:
If only the first is set enabled, there's no problem since after my fix. I couldn't find a way to overwrite the second configuration. However, I don't think that is a real issue. So.. as I can't find a way to remedy this scenario, and the behavior only happens if a user manually enables caching on a page (which probably is rare), I will close this issue for now. If someone else has an idea, be welcome to comment here. |
Update: i found the problem: cache in frontmatter must be disabled
I like your beautiful - and easy to implement!! - gallery. Just a strange behaviour: when you create the gallery and see it in the preview everything is working fine, but as soon as you reload the page you have all the images displayed in a list. The only way to have the correct display back is to clean the cache in GPM.
Working in local environment with the latest version of Grav and admin panel (updated today)
The text was updated successfully, but these errors were encountered: