Skip to content

Commit

Permalink
Merge pull request #10 from salahhusa9/interface-Pipeline
Browse files Browse the repository at this point in the history
Interface pipeline
  • Loading branch information
salahhusa9 committed Oct 22, 2023
2 parents 94a0e5b + 2d7d080 commit 16c0571
Show file tree
Hide file tree
Showing 10 changed files with 32 additions and 8 deletions.
8 changes: 8 additions & 0 deletions src/Contracts/Pipeline.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?php

namespace Salahhusa9\Updater\Contracts;

interface Pipeline
{
public function handle($content, \Closure $next);
}
3 changes: 2 additions & 1 deletion src/Pipelines/ArtisanCallCacheClearPipe.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

use Closure;
use Illuminate\Support\Facades\Artisan;
use Salahhusa9\Updater\Contracts\Pipeline;

class ArtisanCallCacheClearPipe
class ArtisanCallCacheClearPipe implements Pipeline
{
public function handle($content, Closure $next)
{
Expand Down
3 changes: 2 additions & 1 deletion src/Pipelines/ArtisanCallConfigClearPipe.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

use Closure;
use Illuminate\Support\Facades\Artisan;
use Salahhusa9\Updater\Contracts\Pipeline;

class ArtisanCallConfigClearPipe
class ArtisanCallConfigClearPipe implements Pipeline
{
public function handle($content, Closure $next)
{
Expand Down
3 changes: 2 additions & 1 deletion src/Pipelines/ArtisanCallMigratePipe.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

use Closure;
use Illuminate\Support\Facades\Artisan;
use Salahhusa9\Updater\Contracts\Pipeline;

class ArtisanCallMigratePipe
class ArtisanCallMigratePipe implements Pipeline
{
public function handle($content, Closure $next)
{
Expand Down
3 changes: 2 additions & 1 deletion src/Pipelines/ArtisanCallOptimizePipe.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

use Closure;
use Illuminate\Support\Facades\Artisan;
use Salahhusa9\Updater\Contracts\Pipeline;

class ArtisanCallOptimizePipe
class ArtisanCallOptimizePipe implements Pipeline
{
public function handle($content, Closure $next)
{
Expand Down
3 changes: 2 additions & 1 deletion src/Pipelines/ArtisanCallRouteClearPipe.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

use Closure;
use Illuminate\Support\Facades\Artisan;
use Salahhusa9\Updater\Contracts\Pipeline;

class ArtisanCallRouteClearPipe
class ArtisanCallRouteClearPipe implements Pipeline
{
public function handle($content, Closure $next)
{
Expand Down
3 changes: 2 additions & 1 deletion src/Pipelines/ArtisanCallViewClearPipe.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

use Closure;
use Illuminate\Support\Facades\Artisan;
use Salahhusa9\Updater\Contracts\Pipeline;

class ArtisanCallViewClearPipe
class ArtisanCallViewClearPipe implements Pipeline
{
public function handle($content, Closure $next)
{
Expand Down
3 changes: 2 additions & 1 deletion src/Pipelines/GitPipe.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
namespace Salahhusa9\Updater\Pipelines;

use Closure;
use Salahhusa9\Updater\Contracts\Pipeline;
use Salahhusa9\Updater\Facades\Updater;
use Salahhusa9\Updater\Helpers\Git;

class GitPipe
class GitPipe implements Pipeline
{
public function handle($content, Closure $next)
{
Expand Down
3 changes: 2 additions & 1 deletion src/Pipelines/SeedersPipe.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

use Closure;
use Illuminate\Support\Facades\Artisan;
use Salahhusa9\Updater\Contracts\Pipeline;

class SeedersPipe
class SeedersPipe implements Pipeline
{
public function handle($content, Closure $next)
{
Expand Down
8 changes: 8 additions & 0 deletions src/Updater.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@ private function updateTo($version): string
$pipelines[] = config('updater.after_update_pipelines');
}

foreach ($pipelines as $key => $pipeline) {
if (! is_object($pipeline) && ($pipeline instanceof \Salahhusa9\Updater\Contracts\Pipeline)) {

Check failure on line 77 in src/Updater.php

View workflow job for this annotation

GitHub Actions / phpstan

Call to function is_object() with 'Salahhusa9\\Updater\\Pipelines\\ArtisanCallCacheClearPipe'|'Salahhusa9\\Updater\\Pipelines\\ArtisanCallConfigClearPipe'|'Salahhusa9\\Updater\\Pipelines\\ArtisanCallMigratePipe'|'Salahhusa9\\Updater\\Pipelines\\ArtisanCallOptimizePipe'|'Salahhusa9\\Updater\\Pipelines\\ArtisanCallRouteClearPipe'|'Salahhusa9\\Updater\\Pipelines\\ArtisanCallViewClearPipe'|'Salahhusa9\\Updater\\Pipelines\\GitPipe'|'Salahhusa9\\Updater\\Pipelines\\SeedersPipe'|non-empty-array will always evaluate to false.

Check failure on line 77 in src/Updater.php

View workflow job for this annotation

GitHub Actions / phpstan

Instanceof between array|string and Salahhusa9\Updater\Contracts\Pipeline will always evaluate to false.

Check failure on line 77 in src/Updater.php

View workflow job for this annotation

GitHub Actions / phpstan

Result of && is always false.
unset($pipelines[$key]);
} else {
throw new \Exception('Pipeline must be implement \Salahhusa9\Updater\Contracts\Pipeline');
}
}

Pipeline::send([

Check failure on line 84 in src/Updater.php

View workflow job for this annotation

GitHub Actions / phpstan

Unreachable statement - code above always terminates.
'current_version' => $this->getCurrentVersion(),
'new_version' => $version,
Expand Down

0 comments on commit 16c0571

Please sign in to comment.