Changed ASOMSG_Length to ASOMSG_Size. ASOMSG_Length only changes

what is stored in mn_Length. It does not change the allocation size used so anything written past the normal message structure would have trashed innocent memory in earlier versions.
salass00 · Sep 30, 2016 · 4143715 · 4143715
1 parent 7eb058b
commit 4143715
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/cli.c b/src/cli.c
@@ -57,8 +57,8 @@ int cli_main(struct LocaleInfo *loc) {
 	}
 
 	startup_msg = IExec->AllocSysObjectTags(ASOT_MESSAGE,
-		ASOMSG_Name,   PROGNAME " startup message",
-		ASOMSG_Length, sizeof(*startup_msg),
+		ASOMSG_Name, PROGNAME " startup message",
+		ASOMSG_Size, sizeof(*startup_msg),
 		TAG_END);
 	if (startup_msg == NULL) {
 		IDOS->PrintFault(ERROR_NO_FREE_STORE, PROGNAME);
@@ -102,7 +102,7 @@ int cli_main(struct LocaleInfo *loc) {
 	death_msg = IExec->AllocSysObjectTags(ASOT_MESSAGE,
 		ASOMSG_Name,      PROGNAME " death message",
 		ASOMSG_ReplyPort, mp,
-		ASOMSG_Length,    sizeof(*death_msg),
+		ASOMSG_Size,      sizeof(*death_msg),
 		TAG_END);
 	if (death_msg == NULL) {
 		IDOS->PrintFault(ERROR_NO_FREE_STORE, PROGNAME);

diff --git a/src/gui.c b/src/gui.c
@@ -992,16 +992,16 @@ int gui_main(struct LocaleInfo *loc, struct WBStartup *wbs) {
 		goto out;
 
 	gd->startup_msg = IExec->AllocSysObjectTags(ASOT_MESSAGE,
-		ASOMSG_Name,   PROGNAME " startup message",
-		ASOMSG_Length, sizeof(*gd->startup_msg),
+		ASOMSG_Name, PROGNAME " startup message",
+		ASOMSG_Size, sizeof(*gd->startup_msg),
 		TAG_END);
 	if (gd->startup_msg == NULL)
 		goto out;
 
 	gd->death_msg = IExec->AllocSysObjectTags(ASOT_MESSAGE,
 		ASOMSG_Name,      PROGNAME " death message",
 		ASOMSG_ReplyPort, gd->srec_mp,
-		ASOMSG_Length,    sizeof(*gd->death_msg),
+		ASOMSG_Size,      sizeof(*gd->death_msg),
 		TAG_END);
 	if (gd->death_msg == NULL)
 		goto out;