Suggested fix for issue #7: Kafka::consume exits if set_partition was not called #8

EVODelavega · 2015-03-31T12:28:16Z

Added a partition property to the Kafka class
Set partition when Kafka::consume is called without calling set_partition first
Fixed format string used to write to syslog (%d of int64_t -> PRId64, %d for char *offset -> %s)
Updated the READEME.md
Check argument value passed to Kafka::set_partition -> throws exception in case of an invalid argument
Reduce wait in kafka_destroy to 10ms
Add checks to return value of msg_consume, only adding actual messages to return_value
Add destructor, so as to not postpone rd_kafka_Destroy needlessly

Possible follow-up PR:

add connect and disconnect methods, perhaps allowing users to specify the wait in MS
Add beginning and end offset constants
Deprecate the set_partition method, and replace it with a more PSR-compliant setPartition method (camel-cased methods are preferred 21 to 1 -> http://www.php-fig.org/psr/psr-2/)

…fset is int64_t)

…out set_partition first

…ing messages, too

…in Kafka::produce anymore

…ead_count < 0

…into consume-fix * 'consume-fix' of https://github.com/EVODelavega/phpkafka: Check msg_consume return value for NULL pointer to avoid segfault

* commit '19c892a28629696ff0c75a4d1001edd756e188f4': Add getPartitionOffsets method (not ready to be used, though)

Elias Van Ootegem added 5 commits March 31, 2015 14:02

Check partition is set + update readme

17aa503

Fix format specifiers in kafka_consume (offset is char * and start_of…

a2f62c9

…fset is int64_t)

Fallback to default producing partition (0) if consume is called with…

dc19f9e

…out set_partition first

Check partition property, and set it to default partition when produc…

1032392

…ing messages, too

Declare partition zval* before using it...

41964c6

EVODelavega mentioned this pull request Mar 31, 2015

Consume function fails #7

Open

Elias Van Ootegem and others added 20 commits March 31, 2015 15:09

Throw exception if set_partition argument is invalid

de92ff5

make Kafka::produce return the partition (int), do not set partition …

8d39971

…in Kafka::produce anymore

use add_next_index_stringl to add messages to the return value

051316e

Do not wait when kafka_destroy is called, and break consume loop if r…

dd6a1e6

…ead_count < 0

Check msg_consume return value for NULL pointer to avoid segfault

d7df500

Fix segfault when read_count is negative

d8f4d79

Merge branch 'consume-fix' of https://github.com/EVODelavega/phpkafka …

e832845

…into consume-fix * 'consume-fix' of https://github.com/EVODelavega/phpkafka: Check msg_consume return value for NULL pointer to avoid segfault

Use offsets as indexes again, but ensure payload is at least 1 char long

263f987

Fix sprintf typo + use offset as key

f94dfcc

Add wait call again, leaving it out causes segfault

05e9e5f

Add destructor, enables faster connection closing

91c1e2d

Deprecate set_partition + add disconnect method

9d492aa

Add offset constants

f71abe2

Make class final + add isConnected method to check connection status

adfed89

Allow for constants passed to consume

01e206d

Add proto comments to php_kafka.c

b612c19

Add Kafka stub class

6284538

Experimental commit -> get the partitions for a given topic

7d5affe

Ensure rk is of the correct/required type

461c157

Fix experimental commit

358238d

EVODelavega closed this Apr 9, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggested fix for issue #7: Kafka::consume exits if set_partition was not called #8

Suggested fix for issue #7: Kafka::consume exits if set_partition was not called #8

EVODelavega commented Mar 31, 2015

Suggested fix for issue #7: Kafka::consume exits if set_partition was not called #8

Suggested fix for issue #7: Kafka::consume exits if set_partition was not called #8

Conversation

EVODelavega commented Mar 31, 2015