Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsedown-extra support for php7.4 #189

Merged
merged 6 commits into from
Jan 20, 2020
Merged

parsedown-extra support for php7.4 #189

merged 6 commits into from
Jan 20, 2020

Conversation

drjdr
Copy link
Contributor

@drjdr drjdr commented Dec 29, 2019

No description provided.

@ayimdomnic
Copy link

@saleem-hadad Can this be merged?

@anianweber
Copy link

@saleem-hadad yea, i would also really apreciate if you merge this.

@hedeqiang
Copy link

Can this be merged?

@SerafimArts
Copy link

@drjdr can you please publish your fork on the packagist? Since, apparently, corrections in main repo in the near future we will not wait.)))

@TheFrankman
Copy link

@saleem-hadad - bump

@ayimdomnic
Copy link

@SerafimArts I agree with you.. looks like this is no-longer maintained

@WillGoldstein
Copy link
Contributor

It's still maintained. @saleem-hadad has started up a discord with some of the contributors (myself included) with the goal of making it better. Unfortunately, he hasn't given anyone any power yet, and has been unresponsive lately.

@drjdr
Copy link
Contributor Author

drjdr commented Jan 14, 2020

@SerafimArts Let's first find out why there is no response anymore before starting a fork on which projects will depend.
I use the following currently for a small project on mine where I use this for the docs.

"binarytorch/larecipe": "dev-master",
Change the required version to dev-master

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/drjdr/larecipe"
        }
    ]

Add the above to your composer.json file, which will help you until this gets merged.
See https://getcomposer.org/doc/05-repositories.md#vcs

I have seen that the tests are very limited in this projects, e.g. the last commit solves an issue which you get when generating the docs. But all the tests succeeded already the commit before :/

@SerafimArts
Copy link

@drjdr I can’t do this, since the assembly servers do not have access to the github (security reasons), and all the inquiries go to the artifactory, which in turn goes to the packagist.

@drjdr
Copy link
Contributor Author

drjdr commented Jan 15, 2020

@drjdr I can’t do this, since the assembly servers do not have access to the github (security reasons), and all the inquiries go to the artifactory, which in turn goes to the packagist.

@SerafimArts Feel free to fork my patch and add it to your packagist as well. It will keep you in control of your code and requirements. I have no intent of maintaining a version of this software. :)

@SerafimArts
Copy link

@drjdr kk, thx

@SerafimArts
Copy link

SerafimArts commented Jan 15, 2020

P.S. If someone needs it: https://packagist.org/packages/serafim/larecipe v2.3.0

@saleem-hadad saleem-hadad merged commit 39920c9 into saleem-hadad:master Jan 20, 2020
@saleem-hadad
Copy link
Owner

saleem-hadad commented Jan 20, 2020

Sorry guys for being late, I was on holiday with my wife on honeymoon

@saleem-hadad
Copy link
Owner

I'll release a new version tonight

@saleem-hadad
Copy link
Owner

thank you all, this project is still maintained periodically
don't worry

@drjdr
Copy link
Contributor Author

drjdr commented Jan 20, 2020

Congrats Saleem! and thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants