Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Date Range Filtering #19

Merged
merged 1 commit into from
May 18, 2024

Conversation

imahmood
Copy link
Collaborator

This pull request introduces two new methods (dateFrom and dateTo) to the BaseFilter class. These methods allow filtering queries based on a specified date range.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.82%. Comparing base (19281f9) to head (bd877c2).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #19      +/-   ##
============================================
- Coverage     93.95%   92.82%   -1.13%     
- Complexity       69       73       +4     
============================================
  Files             5        5              
  Lines           215      223       +8     
============================================
+ Hits            202      207       +5     
- Misses           13       16       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salehhashemi1992
Copy link
Owner

@imahmood
Thank you for your contribution. Would it be possible for you to also include the corresponding tests?

@salehhashemi1992 salehhashemi1992 merged commit b65075a into main May 18, 2024
11 of 12 checks passed
@salehhashemi1992 salehhashemi1992 deleted the feature/date-range-filter branch May 18, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants