Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 3 Upgrade #39

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Ruby 3 Upgrade #39

merged 5 commits into from
Apr 29, 2021

Conversation

chadmetcalf-cb
Copy link
Contributor

@chadmetcalf-cb chadmetcalf-cb commented Apr 29, 2021 •
edited
Loading

  • Ruby 2.7 / 3.0 argument handling changes
  • bump Ruby version to 2.7 / 3.0
  • dependency changes due to ruby version
  • rubocop changes due to dependency bump
  • consistent bundler version between crossdock and root Gemfiles
  • Docker uses correct ruby & bundler versions in container build

@indrekj
Copy link
Member

indrekj commented Apr 29, 2021

Nice. Can you add 3.0 to travis.yml as well: https://github.com/salemove/jaeger-client-ruby/blob/master/.travis.yml#L5 ?

@indrekj
Copy link
Member

indrekj commented Apr 29, 2021

🎉

@indrekj indrekj merged commit 3ec3d8c into salemove:master Apr 29, 2021
@tnir tnir mentioned this pull request May 31, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chadmetcalf-cb @indrekj