Log empty values to OTEL (#1326)

saleor · Apr 26, 2024 · eec2552 · eec2552
1 parent 3039e7b
commit eec2552
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/.changeset/chatty-roses-fold.md b/.changeset/chatty-roses-fold.md
@@ -0,0 +1,5 @@
+---
+"@saleor/apps-logger": patch
+---
+
+Send empty keys to OTEL. Thanks to that change our queries that consume OTEL will have access to falsy values.
diff --git a/packages/logger/src/logger-otel-transport.ts b/packages/logger/src/logger-otel-transport.ts
@@ -1,7 +1,7 @@
-import { ILogObj, Logger } from "tslog";
-import { LogAttributeValue, logs } from "@opentelemetry/api-logs";
 import { context } from "@opentelemetry/api";
+import { LogAttributeValue, logs } from "@opentelemetry/api-logs";
 import { SemanticResourceAttributes } from "@opentelemetry/semantic-conventions";
+import { ILogObj, Logger } from "tslog";
 import { LoggerContext } from "./logger-context";
 
 export const attachLoggerOtelTransport = (
@@ -29,13 +29,6 @@ export const attachLoggerOtelTransport = (
       ...attributes,
     }).reduce(
       (acc, [key, value]) => {
-        /**
-         * Prune empty keys, to save bandwidth
-         */
-        if (!value) {
-          return acc;
-        }
-
         if (Array.isArray(value)) {
           acc[key] = JSON.stringify(value);
         } else {