Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PR diff instead of pnpm action for changesets #1465

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Use PR diff instead of pnpm action for changesets #1465

merged 2 commits into from
Jul 4, 2024

Conversation

krzysztofzuraw
Copy link
Member

Scope of the PR

Related issues

Checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 51b5683

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax 🛑 Canceled (Inspect) 💬 Add feedback Jul 4, 2024 10:43am
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 10:43am
saleor-app-data-importer 🛑 Canceled (Inspect) 💬 Add feedback Jul 4, 2024 10:43am
saleor-app-emails-and-messages ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 10:43am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 10:43am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 10:43am
saleor-app-search 🛑 Canceled (Inspect) 💬 Add feedback Jul 4, 2024 10:43am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 10:43am

@krzysztofzuraw krzysztofzuraw changed the title Fix changset action Fix changeset action Jul 4, 2024
@krzysztofzuraw krzysztofzuraw changed the title Fix changeset action Use PR diff instead of pnpm action for changesets Jul 4, 2024
@krzysztofzuraw
Copy link
Member Author

Workflow works as it should: https://github.com/saleor/apps/actions/runs/9792864390/job/27039565987?pr=1465

@krzysztofzuraw krzysztofzuraw added the skip changeset Attach this label to PRs which does not need changes description for the release notes. label Jul 4, 2024
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review July 4, 2024 10:36
@krzysztofzuraw krzysztofzuraw requested a review from a team as a code owner July 4, 2024 10:36
@krzysztofzuraw krzysztofzuraw requested a review from a team July 4, 2024 10:36
@krzysztofzuraw krzysztofzuraw enabled auto-merge (squash) July 4, 2024 10:45
@krzysztofzuraw krzysztofzuraw merged commit f72af1a into main Jul 4, 2024
21 of 23 checks passed
@krzysztofzuraw krzysztofzuraw deleted the fix-changeset-aciton branch July 4, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyanKiyoshi NyanKiyoshi NyanKiyoshi approved these changes

@lkostrowski lkostrowski lkostrowski approved these changes

@poulch poulch poulch approved these changes

Assignees

@krzysztofzuraw krzysztofzuraw

Labels
skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krzysztofzuraw @NyanKiyoshi @lkostrowski @poulch