Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Saleor App submission via PRs #265

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Remove the Saleor App submission via PRs #265

merged 1 commit into from
Aug 10, 2022

Conversation

zaiste
Copy link
Contributor

@zaiste zaiste commented Aug 9, 2022

Fixes #225

@zaiste zaiste requested review from 2can and lkostrowski August 9, 2022 14:03
@zaiste zaiste added this to the 1.14 milestone Aug 9, 2022
@zaiste zaiste self-assigned this Aug 9, 2022
2can
2can suggested changes Aug 9, 2022
View reviewed changes
Copy link
Member

@2can 2can left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zaiste please remove publish from /src/cli/app/index.ts

@lkostrowski
Copy link
Member

Let's also remove from docs, e.g.
https://docs.saleor.io/docs/3.x/cli#app

@zaiste
Copy link
Contributor Author

zaiste commented Aug 10, 2022

saleor/saleor-docs#485

@2can 2can merged commit 5724db6 into main Aug 10, 2022
@2can 2can deleted the remove-publish-feature branch August 10, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2can 2can 2can approved these changes

@lkostrowski lkostrowski Awaiting requested review from lkostrowski

Assignees

@zaiste zaiste

Labels
None yet
Projects
No open projects
Devtools
Archived in project
Milestone
1.14
Development

Successfully merging this pull request may close these issues.

Submitting apps for review to marketplace
3 participants
@zaiste @lkostrowski @2can