Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing header in app deploy #296

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Add missing header in app deploy #296

merged 1 commit into from
Aug 26, 2022

Conversation

2can
Copy link
Member

@2can 2can commented Aug 26, 2022

  • the fetch api body data type must match "Content-Type" header

@2can
Add missing header in app deploy
5ef3120 
* the fetch api body data type must match "Content-Type" header
@2can 2can added this to the 1.14 milestone Aug 26, 2022
lkostrowski
lkostrowski approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@lkostrowski lkostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it solve broken deployment token env setting in vercel?

@2can
Copy link
Member Author

2can commented Aug 26, 2022

No, it's just one step in the puzzle

@2can 2can linked an issue Aug 26, 2022 that may be closed by this pull request
App deploy doesnt set deployment token in Vercel #297
Closed
@zaiste zaiste merged commit 518ebcc into main Aug 26, 2022
@zaiste zaiste deleted the app-deploy branch August 26, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaiste zaiste zaiste approved these changes

@lkostrowski lkostrowski lkostrowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Devtools
Archived in project
Milestone
1.14
Development

Successfully merging this pull request may close these issues.

App deploy doesnt set deployment token in Vercel
3 participants
@2can @zaiste @lkostrowski