Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .env file requirement for app commands #316

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Remove .env file requirement for app commands #316

merged 1 commit into from
Sep 2, 2022

Conversation

2can
Copy link
Member

@2can 2can commented Sep 2, 2022

**I want to merge this PR because: ***

It removes the .env file requirement for app create and app deploy commands. No environment variables from the .env file are required for the aforementioned commands.

In the same time the app create doesn't require

Related issues

Steps to test feature

  • create an app saleor app create - in the created folder there should be no .env file, and there should be no prompt for the organization and the environment
  • deploy an app saleor app deploy - the .env file should not be required to deploy an app

I have:

  • Tested it locally and it doesn't break existing features
  • Added documentation if public changes are introduced
  • Added tests for my code

@zaiste zaiste merged commit 26a4514 into main Sep 2, 2022
@zaiste zaiste deleted the remove-env branch September 2, 2022 13:31
@zaiste zaiste added this to the 1.14 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants