Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storefront create with react-storefront #337

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Update storefront create with react-storefront #337

merged 1 commit into from
Sep 7, 2022

Conversation

2can
Copy link
Member

@2can 2can commented Sep 7, 2022 •
edited by zaiste
Loading

I want to merge this PR because
It aligns storefront create with react-storefront recent changes

Related issues

Steps to test feature

I have:

  • Tested it locally and it doesn't break existing features
  • Added documentation if public changes are introduced
  • Added tests for my code

@2can 2can requested a review from a team September 7, 2022 11:42
@zaiste zaiste merged commit 47a60cd into main Sep 7, 2022
@zaiste zaiste deleted the store-create branch September 7, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaiste zaiste zaiste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@2can @zaiste