Update deploy commands #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2can
force-pushed
the
deploy-flow
branch
2 times, most recently
from
bb1b002
to
0453e9c
Compare
* Use only required environment variables. Mainly Saleor graphql
endpoint. Skip reading .env file.
* Create contentBox - replacement for boxen
zaiste
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this PR because:
It updates and unifies the deploy commands.
It uses the
react-storefrontrepository for checkout deployment.It removes the
.envdependency for deployment.It unifies the deployment process.
It introduces
contentBoxinstead of boxen ones for better handling of long texts/URLssaleor app deploysaleor checkout deploysaleor storefront deployRelated issues
Steps to test feature
I have: