Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Select input #245

Closed
1 task done
krzysztofzuraw opened this issue Feb 6, 2023 · 1 comment · Fixed by #414
Closed
1 task done

Implement Select input #245

krzysztofzuraw opened this issue Feb 6, 2023 · 1 comment · Fixed by #414
Assignees
@krzysztofzuraw
Labels
next Next version of Macaw UI

Comments

@krzysztofzuraw
Copy link
Member

krzysztofzuraw commented Feb 6, 2023 •
edited

What I'm trying to achieve

I want a dropdown input with the new MacawUI design based on Figma.

Describe a proposed solution

We should implement Dropdown on top of BaseInput from #232. This story is only about simple Dropdowns without autocomplete.

We should also check the current Dashboard for MUI Dropdown usage and add the missing API

As #342 will be merged we can add a new prop to combobox that will allow users only to select a value from combobox without autocomplete.

Acceptance Criteria

  • Implement new inputs according to the design
@krzysztofzuraw krzysztofzuraw mentioned this issue Feb 6, 2023
Closed
15 tasks
@krzysztofzuraw krzysztofzuraw added the next Next version of Macaw UI label Apr 14, 2023
@krzysztofzuraw krzysztofzuraw changed the title Implement Dropdown input Implement Dropdown/Select input Apr 14, 2023
@krzysztofzuraw krzysztofzuraw mentioned this issue Apr 14, 2023
Merged
@krzysztofzuraw krzysztofzuraw changed the title Implement Dropdown/Select input Implement Select input Apr 27, 2023
@krzysztofzuraw krzysztofzuraw self-assigned this Apr 27, 2023
@krzysztofzuraw krzysztofzuraw mentioned this issue Apr 28, 2023
Merged
2 tasks
@krzysztofzuraw
Copy link
Member Author

Link to acceptance: https://macaw-ui-next-git-feat-245select-saleorcommerce.vercel.app/?path=/docs/components-select--docs#controlled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzysztofzuraw krzysztofzuraw

Labels
next Next version of Macaw UI
Projects
Dashboard
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: select component saleor/macaw-ui
1 participant
@krzysztofzuraw