Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Combobox component #342

Merged
merged 19 commits into from
Apr 14, 2023
Merged

Add Combobox component #342

merged 19 commits into from
Apr 14, 2023

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Apr 5, 2023

What was done

  • Added Combobox component to MacawUI
  • Refactored common parts of code for Input and Combobox to BaseInput
  • Added helper from vanilla extract for CSS calc

Screenshots

CleanShot 2023-04-05 at 09 01 13@2x

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 8:48am
macaw-ui-next ✅ Ready (Inspect) Visit Preview 2 resolved Apr 14, 2023 8:48am

@vercel vercel bot temporarily deployed to Preview – macaw-ui April 5, 2023 07:00 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 5, 2023 07:01 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 6, 2023 09:10 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 6, 2023 09:11 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 6, 2023 09:16 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 6, 2023 09:17 Inactive
@krzysztofzuraw krzysztofzuraw linked an issue Apr 6, 2023 that may be closed by this pull request
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 6, 2023 10:12 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 6, 2023 10:13 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 7, 2023 13:29 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 7, 2023 13:30 Inactive
@krzysztofzuraw krzysztofzuraw requested review from a team, andrzejewsky and Droniu and removed request for a team April 7, 2023 13:58
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 12, 2023 10:03 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 12, 2023 10:04 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 13, 2023 06:31 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 13, 2023 06:33 Inactive
@typeofweb
Copy link
Contributor

Looking great! Are there plans to introduce a Select component that's similar to the Combobox but doesn't allow searching?

@@ -0,0 +1,78 @@
import { ComponentMeta, ComponentStory } from "@storybook/react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: can you write a story in a new way so the docs will be generated?

@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 14, 2023 08:46 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 14, 2023 08:48 Inactive
@krzysztofzuraw krzysztofzuraw mentioned this pull request Apr 14, 2023
1 task
@krzysztofzuraw
Copy link
Member Author

@mmiszy good idea - you can track progress in #245

@krzysztofzuraw krzysztofzuraw merged commit 406311d into canary Apr 14, 2023
2 checks passed
@krzysztofzuraw krzysztofzuraw deleted the feat/320/select branch April 14, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Combobox component
4 participants