Fix dialog overflows #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/saleorcommerce/macaw-ui/jVqHrFiV6s5aXhNpjBm1eyeq2SQP |
size-limit report 📦
|
dominik-zeglen
force-pushed
the
fix-dialog-scrolls
branch
from
3dc716a
to
aea1ac7
Compare
Cloud11PL
force-pushed
the
fix-dialog-scrolls
branch
from
ea88a8a
to
5f16e2e
Compare
Cloud11PL
force-pushed
the
fix-dialog-scrolls
branch
from
5f16e2e
to
e36e0de
Compare
dominik-zeglen
requested review from
a team,
bmigirl and
Droniu
and removed request for
a team
Droniu
approved these changes
Oct 14, 2021
bmigirl
approved these changes
Oct 14, 2021
jwm0
reviewed
Oct 14, 2021
| @@ -58,6 +58,11 @@ export const createTheme = (colors: SaleorThemeColors): SaleorTheme => | |||
| fontSize: "1.3rem", | |||
| }, | |||
| }, | |||
| MuiDialog: { | |||
| paper: { | |||
| overflowY: undefined, | |||
There was a problem hiding this comment.
What does undefined accomplish here? What's the CSS prop value outcome? If it's "initial" then it would be best to type it manually.
There was a problem hiding this comment.
It totally removes value from stylesheet, in my opinion it reduces css bloat
jwm0
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems #54 did not resolve issue in all places.