Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiselect height #695

Merged
merged 3 commits into from
Dec 21, 2023
Merged

fix: multiselect height #695

merged 3 commits into from
Dec 21, 2023

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Dec 20, 2023

I want to merge this change because it fixes multiselect (static & dynamic) height.

This PR closes #...

Screenshots

Before After
CleanShot 2023-12-20 at 12 53 52@2x CleanShot 2023-12-20 at 12 53 03@2x

Pull Request Checklist

  • New components are exported from ./src/components/index.ts.
  • The storybook story is created and documentation is properly generated.
  • New component is wrapped in forwardRef.

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 9:52am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
macaw-ui ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 9:52am

@vercel vercel bot temporarily deployed to Preview – macaw-ui-next December 20, 2023 11:54 Inactive
@krzysztofzuraw krzysztofzuraw changed the title fix: muliselect height fix: multiselect height Dec 20, 2023
andrzejewsky
andrzejewsky previously approved these changes Dec 21, 2023
src/components/Multiselect/Static/Multiselect.stories.tsx Outdated Show resolved Hide resolved
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review December 21, 2023 09:51
@krzysztofzuraw krzysztofzuraw requested a review from a team as a code owner December 21, 2023 09:51
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next December 21, 2023 09:52 Inactive
@krzysztofzuraw krzysztofzuraw merged commit 4daf772 into canary Dec 21, 2023
10 checks passed
@krzysztofzuraw krzysztofzuraw deleted the fix-multiselect-height branch December 21, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants