Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button font weights #777

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Fix button font weights #777

merged 2 commits into from
Mar 19, 2024

Conversation

Droniu
Copy link
Member

@Droniu Droniu commented Mar 18, 2024

I want to merge this change because it:

  • fixes default button font weight (should be bold)
  • changes bold font weight to 600

Screenshots

Pull Request Checklist

  • New components are exported from ./src/components/index.ts.
  • The storybook story is created and documentation is properly generated.
  • New component is wrapped in forwardRef.

@Droniu Droniu requested a review from a team as a code owner March 18, 2024 13:12
Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: 18d8644

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/macaw-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
macaw-ui ✅ Ready (Inspect) Visit Preview Mar 18, 2024 1:12pm

@@ -9,6 +9,7 @@ export const button = recipe({
placeItems: "center",
padding: 0,
textDecoration: "none",
fontWeight: "bold",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I'd be explicit here nad put 600 instead of bold.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is mapped to token from theme (this is sprinkles context).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also bold is actually 700 in the web API, perhaps it should be changed to semibold in sprinkles tokens

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave up to you - you will need to migrate Dashboard as well 🤔

@Droniu Droniu added the release dev tag Release pkg to npm with @dev tag label Mar 18, 2024
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240318132510.

Install it with:

pnpm add @saleor/macaw-ui@0.0.0-pr-20240318132510

@Droniu Droniu merged commit 604c7a0 into main Mar 19, 2024
7 of 9 checks passed
@Droniu Droniu deleted the merx-242-fix-button-font-weights branch March 19, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release dev tag Release pkg to npm with @dev tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants