Add text color button variants #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominik-zeglen
requested review from
a team,
Cloud11PL and
jwm0
and removed request for
a team
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/saleorcommerce/macaw-ui/6fzxN8XNDUmDTf9pYrZdo7aGhuvJ |
size-limit report 📦
|
jwm0
suggested changes
Nov 22, 2021
| @@ -65,15 +53,17 @@ const DefaultStory: React.FC = () => { | |||
| <Button disabled variant="secondary"> | |||
| Secondary | |||
| </Button> | |||
| <Button variant="secondary" color="text"> | |||
There was a problem hiding this comment.
I believe the color type should be specified somewhere in the storybook, otherwise I don't know what I'm looking at if I don't see the code(I see 2 disabled buttons with exact same styling).
There was a problem hiding this comment.
That's a good idea
Cloud11PL
approved these changes
Nov 25, 2021
jwm0
approved these changes
Nov 25, 2021
dominik-zeglen
added a commit
that referenced
this pull request
Jan 11, 2022
* Add text color button variants * Indicate variant in button label
dominik-zeglen
added a commit
that referenced
this pull request
Jan 11, 2022
* Restyle pagination * Fix specificity * Update usermenu design * Improve backlink styles * Improve button styles * Improve disabled state * Fix disabled state * Update theme * Update sidebar styles * Forward ref to button * Update menu styles * Update link color * Add icons as components * Add status chip * Improve tooltip styles * Remove classnames * Fix light divider color * Add page tabs * Add PageTabPanel component * Export page tab panel * Improve tab styles * Update outlined button style * Add disabled state to backlink * Add edit icon * Disable padding on menu * Forward ref to square button * Improve card padding * Do not double padding when card header is present * Change action buttons placement * Fix card actions padding * Restrict top level mui imports * wip * Retain order * Add various filter fields * Do not use any type * Add initial state * Export filter icon * Update chip styles * Add delete icon * Export delete icon * Fix outlined button color * Add hover * Fix button height * Add disabled state to SquareButton * Silence warnings * Allow confirm button to have variants * Extract AlertBase from Alert * Fix rebase artifact * Improve layout button hover and focus styles * Fix import * Export action bar * (0.3) Create status icons components (#52) * Create status icons components * Update icons names * Update icons exports * Remove legacy icons * Update icons props * Change package limit size * Update icons names * Add image icon * Add story for icons * Add builder and watcher * Remove tsdx * Add jest * Fix jest env * Update input appearance * Fix copy * Silence eslint import errors * Fix label colors * Get rid of input theme colors * Lint * Remove type casting * Use "concurrently" * Fix logging * Remove unused packages * Use console time * Add fixture generator * Remove dividers from dialogs * Add dialog utils * Fix size * Improve hook api * Export hooks * Apply suggestions from review * Add plus icon * Use only one shadow type * Update button design * Add keyboard interaction states * Fix disabled color * Simplify code * Add icon button * Fix disabled state * Fix dark theme * wip * Add clickable pill component * Fix dialog close icon * Set page headers size to 40px * Improve layout button styles * Update user chip component * wip * Fix layout button styles * Move layout button stories to button stories * Fix expand button states * Fix sidebar styles * Fix import * Extract to type * Rename prop * Fix sidebar hover * rfix padding, remove X overflow * Add secondary icon button * Add className to chip * Various fixes * Fix input error state to have outline * Add outline to icon button * Increase clickable area * Fix confirm button * Remove ripple * Allow button components to be overriden * Disable ripple * Remove margin in icons * Fix savebar height * 0.3.0-a.1 * Add chromatic (#78) * Add chromatic * Add actions workflow * Use single workflow * Rework controls (#77) * Rename file to tsx * Update checkbox style * Update radio styles * Update switch styles * Update radio icons * Add animations * Use common animation * Improve clickable area * Fix background * Fix label margin * Fix label margins * Fix indeterminate color * Fix transparency * List styles (#80) * wip * Update table appearance * Update pagination styles * Improve hover effect * Add base list * Add offsetted list * Add list component * Remove unused import * Export new components * Add action and checkbox sizing * Fix padding * Use proper grid sizing * Fix minor visual bugs * Apply suggestions from code review Co-authored-by: Dawid Tarasiuk <tarasiukdawid@gmail.com> * Fix stories * Increase size limit Co-authored-by: Dawid Tarasiuk <tarasiukdawid@gmail.com> * Add edit & search icons (#82) (#85) * 0.3.0-a.2 * Make Alert title optional (#86) (#89) * Make title optional * Without title story * Fix link * Add text color button variants (#84) * Add text color button variants * Indicate variant in button label * Add textarea styles (#88) * Update savebar buttons (#90) * 0.3.0-a.3 * Fix dashboard bugs (#87) * Hide no of rows if not provided * Improve shadow when elevated * Fix expander button * Add navigator icon * Fix z order * Rename prop to camelcase * 0.3.0-a.4 * Fix module (#91) * Output cjs * Build cjs and esm * Add node platrofm * Update size-limit config * Fix module path * 0.3.0-a.5 * Add navigation card (#92) * Rework buttons (#93) * Fix spacing * Fix colors * Add button with icon * Fix guide styles * Fix typography * Make hoverOutline defauls * Pass props to component's root * Use proper typography * Add icons (#95) * Add icon code generator * Add script to build icons index file * Add command to build icons/index.ts * Add icons * Update story design * Add expand icon * Remove logging * Improve input adornments when input is disabled (#94) * Update dark mode colors (#96) * Fix dark mode colors * Add dark palette * Update icons * 0.3.0-a.6 * Minor fixes (#97) * Fix letter spacing * Fix sidebar styles * Fix misplaced elements in responsive mode (#99) * Add letter spacing and fix font family (#98) * Add letter spacing and fix font family * Fix savebar height * 0.3.0-a.7 * Fix rebase artifact * Update size limits Co-authored-by: Dawid Tarasiuk <tarasiukdawid@gmail.com> Co-authored-by: Wojciech Miśta <wojciech.mista@saleor.io> Co-authored-by: Jakub Majorek <majorek.jakub@gmail.com> Co-authored-by: Michał Droń <dron.official@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
color="text"prop to Button component.Screenshot:
