Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bugs #244

Merged
merged 7 commits into from
Nov 7, 2019
Merged

Fix minor bugs #244

merged 7 commits into from
Nov 7, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it fixes some things:

  1. user is now able to create customer without address
  2. broken messages due to different variable names
  3. country field in addresses is now properly validated

Screenshots

image (1)
image (2)

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #244 into master will decrease coverage by 0.02%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage      74%   73.97%   -0.03%     
==========================================
  Files         590      591       +1     
  Lines        6182     6195      +13     
  Branches     1040     1040              
==========================================
+ Hits         4575     4583       +8     
- Misses       1425     1430       +5     
  Partials      182      182
Impacted Files Coverage Δ
.../OrderDraftCancelDialog/OrderDraftCancelDialog.tsx 100% <ø> (ø) ⬆️
.../OrderAddressEditDialog/OrderAddressEditDialog.tsx 76.92% <100%> (+4.19%) ⬆️
...ts/CustomerAddressDialog/CustomerAddressDialog.tsx 88% <100%> (+1.04%) ⬆️
src/hooks/useAddressValidation.ts 44.44% <44.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e6743...f600c3f. Read the comment docs.

@dominik-zeglen dominik-zeglen merged commit 45a56bb into master Nov 7, 2019
@dominik-zeglen dominik-zeglen deleted the fix/minor-bugs branch November 7, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants