Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secret fields in plugin configuration #246

Merged
merged 9 commits into from
Nov 12, 2019
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds support for fields like secrets and passwords in plugin configuration.

Screenshots

Screenshot 2019-11-08 at 11 44 50

Screenshot 2019-11-08 at 11 44 59

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #246 into master will decrease coverage by 0.38%.
The diff coverage is 55.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   74.52%   74.14%   -0.39%     
==========================================
  Files         593      600       +7     
  Lines        6351     6451     +100     
  Branches     1043     1060      +17     
==========================================
+ Hits         4733     4783      +50     
- Misses       1435     1482      +47     
- Partials      183      186       +3
Impacted Files Coverage Δ
src/plugins/urls.ts 85.71% <ø> (ø) ⬆️
src/intl.ts 100% <ø> (ø) ⬆️
src/plugins/fixtures.ts 100% <ø> (ø) ⬆️
src/components/ActionDialog/ActionDialog.tsx 100% <ø> (ø) ⬆️
src/plugins/utils.ts 100% <100%> (ø)
src/plugins/views/PluginsDetails.tsx 16.27% <19.35%> (ø)
...rc/storybook/stories/plugins/PluginDetailsPage.tsx 60% <33.33%> (-11.43%) ⬇️
...luginSecretFieldDialog/PluginSecretFieldDialog.tsx 45.45% <45.45%> (ø)
...retFieldDialog/PluginSecretFieldDialog.stories.tsx 66.66% <66.66%> (ø)
...onents/PluginAuthorization/PluginAuthorization.tsx 82.35% <82.35%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09295a5...8aa97b0. Read the comment docs.

@maarcingebala maarcingebala merged commit 8170f9e into master Nov 12, 2019
@maarcingebala maarcingebala deleted the add/plugin-fields branch November 12, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants