Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subcategories pagination #249

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Conversation

dominik-zeglen
Copy link
Contributor

Resolves #72

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   74.52%   74.52%           
=======================================
  Files         593      593           
  Lines        6351     6351           
  Branches     1043     1043           
=======================================
  Hits         4733     4733           
  Misses       1435     1435           
  Partials      183      183
Impacted Files Coverage Δ
src/categories/fixtures.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5aefb1...000579e. Read the comment docs.

@maarcingebala maarcingebala merged commit 09295a5 into master Nov 12, 2019
@maarcingebala maarcingebala deleted the fix/subcategories-pagination branch November 12, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next button on subcategories does not work (Dashboard 2.0)
2 participants