Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use searches as hooks instead of components #262

Merged
merged 13 commits into from
Nov 21, 2019
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it simplifies code and prepares code to be navigator-ready.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #262 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   74.02%   74.02%   -0.01%     
==========================================
  Files         605      605              
  Lines        6491     6490       -1     
  Branches     1063     1063              
==========================================
- Hits         4805     4804       -1     
  Misses       1501     1501              
  Partials      185      185
Impacted Files Coverage Δ
...ation/components/MenuItemDialog/MenuItemDialog.tsx 53.57% <ø> (ø) ⬆️
...ts/AssignAttributeDialog/AssignAttributeDialog.tsx 90.9% <ø> (ø) ⬆️
.../orders/components/OrderCustomer/OrderCustomer.tsx 55.1% <ø> (ø) ⬆️
...onents/AssignProductDialog/AssignProductDialog.tsx 66.66% <ø> (ø) ⬆️
src/productTypes/fixtures.ts 100% <ø> (ø) ⬆️
src/products/utils/data.ts 83.87% <ø> (ø) ⬆️
...rders/components/OrderDraftPage/OrderDraftPage.tsx 100% <ø> (ø) ⬆️
...components/ProductCreatePage/ProductCreatePage.tsx 92.3% <ø> (ø) ⬆️
...components/ProductUpdatePage/ProductUpdatePage.tsx 93.93% <ø> (ø) ⬆️
src/orders/fixtures.ts 100% <ø> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b459f7...44ba4c5. Read the comment docs.

@maarcingebala maarcingebala merged commit 29bd1a4 into master Nov 21, 2019
@maarcingebala maarcingebala deleted the ref/hook-searches branch November 21, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants