Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint #285

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Use eslint #285

merged 5 commits into from
Dec 3, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because tslint is deprecated and this fixes memory leaks and speeds up linting a little bit.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #285 into master will decrease coverage by 0.04%.
The diff coverage is 36.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   73.97%   73.93%   -0.05%     
==========================================
  Files         606      606              
  Lines        6521     6525       +4     
  Branches     1072     1072              
==========================================
  Hits         4824     4824              
- Misses       1510     1514       +4     
  Partials      187      187
Impacted Files Coverage Δ
.../storybook/stories/components/MultiSelectField.tsx 100% <ø> (ø) ⬆️
...pleteSelectField/SingleAutocompleteSelectField.tsx 82.14% <ø> (ø) ⬆️
...components/VoucherCreatePage/VoucherCreatePage.tsx 87.5% <ø> (ø) ⬆️
...nslationsEntitiesList/TranslationsEntitiesList.tsx 73.33% <ø> (ø) ⬆️
src/components/RichTextEditor/RichTextEditor.tsx 66.66% <ø> (ø) ⬆️
src/fixtures.ts 36.58% <ø> (ø) ⬆️
src/customers/fixtures.ts 100% <ø> (ø) ⬆️
src/components/MenuToggle.tsx 75% <ø> (ø) ⬆️
...storybook/stories/components/SingleSelectField.tsx 100% <ø> (ø) ⬆️
...s/components/ProductVariantCreateDialog/reducer.ts 85.93% <ø> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20cf7f1...fee6686. Read the comment docs.

@maarcingebala maarcingebala merged commit 1fefa22 into master Dec 3, 2019
@maarcingebala maarcingebala deleted the ref/use-eslint branch December 3, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants