Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table sorting #292

Merged
merged 1 commit into from Dec 18, 2019
Merged

Add table sorting #292

merged 1 commit into from Dec 18, 2019

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Dec 4, 2019

I want to merge this change because it adds sorting to the tables.
Resolves #251

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@netlify
Copy link

netlify bot commented Dec 4, 2019

Deploy preview for saleor-dashboard-stage processing.

Building with commit 9c688d3

https://app.netlify.com/sites/saleor-dashboard-stage/deploys/5df9fdededc3af000a9581de

@dominik-zeglen dominik-zeglen marked this pull request as ready for review December 9, 2019 03:36
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #292 into master will decrease coverage by 1.39%.
The diff coverage is 8.13%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #292     +/-   ##
=========================================
- Coverage    74.3%   72.91%   -1.4%     
=========================================
  Files         607      611      +4     
  Lines        6659     6830    +171     
  Branches     1075     1139     +64     
=========================================
+ Hits         4948     4980     +32     
- Misses       1524     1617     +93     
- Partials      187      233     +46
Impacted Files Coverage Δ
...ces/components/ServiceListPage/ServiceListPage.tsx 100% <ø> (ø) ⬆️
...rc/storybook/stories/orders/OrderDraftListPage.tsx 83.33% <ø> (ø) ⬆️
...s/components/WebhooksListPage/WebhooksListPage.tsx 100% <ø> (ø) ⬆️
...mponents/CollectionListPage/CollectionListPage.tsx 100% <ø> (ø) ⬆️
src/staff/urls.ts 85.71% <ø> (ø) ⬆️
src/components/TableCellHeader/TableCellHeader.tsx 100% <ø> (+9.09%) ⬆️
src/pages/components/PageListPage/PageListPage.tsx 100% <ø> (ø) ⬆️
...nents/WebhooksListPage/WebhookListPage.stories.tsx 71.42% <ø> (ø) ⬆️
src/services/urls.ts 88.88% <ø> (ø) ⬆️
...onents/ServiceListPage/ServiceListPage.stories.tsx 71.42% <ø> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97abf33...9c688d3. Read the comment docs.

Copy link
Member

@tomaszszymanski129 tomaszszymanski129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked sorting on couple of views, looks fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement sorting ability in list views
3 participants