Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dialog handling #296

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Unify dialog handling #296

merged 2 commits into from
Dec 19, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it unifies the way views handle opening and closing modal dialogs.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@netlify
Copy link

netlify bot commented Dec 6, 2019

Deploy preview for saleor-dashboard-stage processing.

Building with commit e12bebf

https://app.netlify.com/sites/saleor-dashboard-stage/deploys/5dfa19cac744e80008d67170

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #296 into master will decrease coverage by 0.03%.
The diff coverage is 40.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
- Coverage   72.91%   72.88%   -0.04%     
==========================================
  Files         611      612       +1     
  Lines        6830     6833       +3     
  Branches     1139     1139              
==========================================
  Hits         4980     4980              
- Misses       1617     1620       +3     
  Partials      233      233
Impacted Files Coverage Δ
src/products/urls.ts 61.9% <ø> (ø) ⬆️
src/configuration/index.tsx 37.5% <ø> (ø) ⬆️
src/plugins/views/PluginsDetails.tsx 17.94% <0%> (+0.87%) ⬆️
src/utils/handlers/dialogActionHandlers.ts 0% <0%> (ø)
src/plugins/urls.ts 85.71% <100%> (ø) ⬆️
src/webhooks/urls.ts 88.88% <88.88%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0456377...e12bebf. Read the comment docs.

Copy link
Member

@tomaszszymanski129 tomaszszymanski129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could possibly use some more sophisticated URL building method, otherwise looks good.

src/plugins/urls.ts Outdated Show resolved Hide resolved
@maarcingebala
Copy link
Member

@dominik-zeglen Please fix conflicting files here.

@maarcingebala maarcingebala merged commit 42fa13b into master Dec 19, 2019
@maarcingebala maarcingebala deleted the ref/unify-modals branch December 19, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants