Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when API_URI is not set #375

Merged
merged 3 commits into from Jan 17, 2020
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it resolves #102

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files         612      612           
  Lines        6834     6834           
  Branches     1139     1138    -1     
=======================================
  Hits         4981     4981           
  Misses       1620     1620           
  Partials      233      233
Impacted Files Coverage Δ
src/config.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d1856...052bc7f. Read the comment docs.

@maarcingebala maarcingebala merged commit b5a4542 into master Jan 17, 2020
@maarcingebala maarcingebala deleted the fix/require-api-uri branch May 4, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running server without API_URI should not be possible
2 participants