Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when one product is selected #391

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Conversation

dominik-zeglen
Copy link
Contributor

Resolves #372
Resolves #387

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #391 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   72.45%   72.45%           
=======================================
  Files         639      639           
  Lines        7116     7116           
  Branches     1183     1183           
=======================================
  Hits         5156     5156           
  Misses       1719     1719           
  Partials      241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4633714...c683191. Read the comment docs.

@maarcingebala maarcingebala merged commit 06d94b7 into master Jan 31, 2020
@AlmogCohen
Copy link

Thanks!

@maarcingebala maarcingebala deleted the fix/list-actions branch February 3, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants