Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column picker errors #393

Merged
merged 3 commits into from
Feb 12, 2020
Merged

Fix column picker errors #393

merged 3 commits into from
Feb 12, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it fixes console errors and clickaway listener.
Ref #384

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #393 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   72.46%   72.46%           
=======================================
  Files         639      639           
  Lines        7118     7118           
  Branches     1184     1184           
=======================================
  Hits         5158     5158           
  Misses       1719     1719           
  Partials      241      241           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d5c24...9a42438. Read the comment docs.

@maarcingebala maarcingebala merged commit f9766a5 into master Feb 12, 2020
@maarcingebala maarcingebala deleted the fix/column-picker branch February 12, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants