Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structurized JSON files instead of PO #403

Merged
merged 7 commits into from
Feb 14, 2020
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it resolves #383
Also fixes all messages with plurals.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #403 into master will decrease coverage by 0.04%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   72.45%   72.41%   -0.05%     
==========================================
  Files         639      639              
  Lines        7120     7127       +7     
  Branches     1184     1185       +1     
==========================================
+ Hits         5159     5161       +2     
- Misses       1720     1725       +5     
  Partials      241      241
Impacted Files Coverage Δ
...buteBulkDeleteDialog/AttributeBulkDeleteDialog.tsx 100% <ø> (ø) ⬆️
...onents/HomeProductListCard/HomeProductListCard.tsx 94.44% <ø> (ø) ⬆️
...ts/OrderBulkCancelDialog/OrderBulkCancelDialog.tsx 71.42% <ø> (ø) ⬆️
...ts/HomeNotificationTable/HomeNotificationTable.tsx 76.92% <ø> (ø) ⬆️
...nDialog/ProductTypeBulkAttributeUnassignDialog.tsx 100% <100%> (ø) ⬆️
src/components/Locale/Locale.tsx 56% <28.57%> (-10.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287f209...7dbc157. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation files use ICU format but are uploaded to Transifex as gettext PO
3 participants