Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store errors in form component #410

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it makes handling form errors more explicit.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #410 into master will increase coverage by 0.04%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   72.48%   72.53%   +0.04%     
==========================================
  Files         639      639              
  Lines        7120     7122       +2     
  Branches     1180     1181       +1     
==========================================
+ Hits         5161     5166       +5     
  Misses       1718     1718              
+ Partials      241      238       -3
Impacted Files Coverage Δ
...ductVariantCreatePage/ProductVariantCreatePage.tsx 77.27% <ø> (ø) ⬆️
.../ShippingZoneCreatePage/ShippingZoneCreatePage.tsx 56.25% <ø> (ø) ⬆️
...mponents/ProductDetailsForm/ProductDetailsForm.tsx 100% <ø> (ø) ⬆️
.../ProductTypeDetailsPage/ProductTypeDetailsPage.tsx 67.85% <ø> (ø) ⬆️
...ributeValueEditDialog/AttributeValueEditDialog.tsx 77.77% <ø> (ø) ⬆️
...ts/CollectionDetailsPage/CollectionDetailsPage.tsx 100% <ø> (ø) ⬆️
...onents/AttributeProperties/AttributeProperties.tsx 100% <ø> (ø) ⬆️
...ts/CustomerCreateDetails/CustomerCreateDetails.tsx 100% <ø> (ø) ⬆️
...mponents/ProductVariantPage/ProductVariantPage.tsx 84.61% <ø> (ø) ⬆️
...discounts/components/VoucherValue/VoucherValue.tsx 90.9% <ø> (ø) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15bdebf...f6aee2d. Read the comment docs.

Copy link
Member

@krzysztofwolski krzysztofwolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@maarcingebala maarcingebala merged commit 1629144 into master Feb 25, 2020
@maarcingebala maarcingebala deleted the ref/do-not-format-errors-in-forms branch February 25, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants