Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset pagination when guest change the sorting of the list #474

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Reset pagination when guest change the sorting of the list #474

merged 4 commits into from
Apr 21, 2020

Conversation

gabmartinez
Copy link
Contributor

@gabmartinez gabmartinez commented Apr 10, 2020

I want to merge this change because reset the pagination when the guest changes the sorting of the list.

Fix #427

Screenshots

Initial load first page and sorted by name column desc

Change paginator next page and sorted by name column desc

Change sorting by email column and redirect to the first page

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #474 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files         658      658           
  Lines        7440     7441    +1     
  Branches     1227     1227           
=======================================
+ Hits         5386     5387    +1     
  Misses       1819     1819           
  Partials      235      235           
Impacted Files Coverage Δ
src/config.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffced45...7226a58. Read the comment docs.

@dominik-zeglen dominik-zeglen merged commit 2c46e57 into saleor:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing sorting option should reset pagination
2 participants