Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product stock management to newest design #515

Merged
merged 2 commits into from
May 5, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it updates product stock management to newest design.

PR intended to be tested with API branch: master

Screenshots

Screenshot 2020-05-04 at 17 48 10

Screenshot 2020-05-04 at 17 48 17

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #515 into master will decrease coverage by 0.21%.
The diff coverage is 22.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
- Coverage   72.33%   72.12%   -0.22%     
==========================================
  Files         711      708       -3     
  Lines        8127     8118       -9     
  Branches     1339     1332       -7     
==========================================
- Hits         5879     5855      -24     
- Misses       1990     2006      +16     
+ Partials      258      257       -1     
Impacted Files Coverage Δ
src/hooks/useFormset.ts 30.00% <0.00%> (-20.00%) ⬇️
...s/components/OrderFulfillPage/OrderFulfillPage.tsx 91.30% <ø> (ø)
src/products/utils/data.ts 84.84% <0.00%> (-2.66%) ⬇️
...c/storybook/stories/products/ProductCreatePage.tsx 28.57% <ø> (+3.57%) ⬆️
...c/storybook/stories/products/ProductUpdatePage.tsx 63.63% <ø> (+2.76%) ⬆️
...book/stories/products/ProductVariantCreatePage.tsx 46.66% <ø> (+9.82%) ⬆️
.../storybook/stories/products/ProductVariantPage.tsx 34.78% <ø> (+4.01%) ⬆️
...components/ProductCreatePage/ProductCreatePage.tsx 71.42% <12.50%> (-9.83%) ⬇️
...ductVariantCreatePage/ProductVariantCreatePage.tsx 58.62% <12.50%> (-10.62%) ⬇️
...components/ProductUpdatePage/ProductUpdatePage.tsx 68.75% <15.38%> (-20.44%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7e26f...f969ddf. Read the comment docs.

Copy link
Member

@krzysztofwolski krzysztofwolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dominik-zeglen dominik-zeglen merged commit 02b3717 into master May 5, 2020
@dominik-zeglen dominik-zeglen deleted the ref/add-warehouse-stocck branch May 5, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants