Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle session expiration #520

Merged
merged 3 commits into from
May 7, 2020
Merged

Handle session expiration #520

merged 3 commits into from
May 7, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it handles jwt token expiration, logging out user. In future this should be refactored, so token will be refreshed.

PR intended to be tested with API branch: master

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #520 into master will decrease coverage by 0.11%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   72.12%   72.00%   -0.12%     
==========================================
  Files         708      709       +1     
  Lines        8118     8134      +16     
  Branches     1332     1335       +3     
==========================================
+ Hits         5855     5857       +2     
- Misses       2006     2020      +14     
  Partials      257      257              
Impacted Files Coverage Δ
src/auth/errors.ts 0.00% <0.00%> (ø)
src/auth/index.tsx 60.00% <ø> (ø)
src/hooks/makeQuery.ts 4.54% <0.00%> (-1.02%) ⬇️
src/intl.ts 100.00% <ø> (ø)
src/mutations.tsx 6.25% <0.00%> (-2.09%) ⬇️
src/queries.tsx 6.06% <0.00%> (-0.84%) ⬇️
src/auth/mutations.ts 100.00% <100.00%> (ø)
src/theme.ts 100.00% <0.00%> (ø)
...s/components/OrderFulfillPage/OrderFulfillPage.tsx 91.30% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8c5b0...375d038. Read the comment docs.

@dominik-zeglen dominik-zeglen merged commit 873ed68 into master May 7, 2020
@dominik-zeglen dominik-zeglen deleted the fix/jwt-expire branch May 7, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants