Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display correct error if there were no graphql errors #525

Merged
merged 3 commits into from
May 11, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it fixes #524

PR intended to be tested with API branch: master

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@dominik-zeglen dominik-zeglen changed the title DIsplay correct error if there were no graphql errors Display correct error if there were no graphql errors May 11, 2020
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #525 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   72.01%   71.99%   -0.02%     
==========================================
  Files         709      709              
  Lines        8137     8135       -2     
  Branches     1337     1336       -1     
==========================================
- Hits         5860     5857       -3     
- Misses       2020     2021       +1     
  Partials      257      257              
Impacted Files Coverage Δ
src/hooks/makeQuery.ts 4.54% <0.00%> (ø)
src/mutations.tsx 5.88% <0.00%> (-0.37%) ⬇️
src/queries.tsx 6.06% <0.00%> (ø)
...s/components/OrderFulfillPage/OrderFulfillPage.tsx 91.30% <0.00%> (-0.54%) ⬇️
src/orders/queries.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9c6f6...355fe30. Read the comment docs.

@dominik-zeglen dominik-zeglen merged commit 65d7659 into master May 11, 2020
@dominik-zeglen dominik-zeglen deleted the fix/network-error branch May 11, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: user.logout is not a function
2 participants