New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style of product type attributes empty table #744
Conversation
Task linked: SALEOR-1247 Broken table on product type view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Storybook seems to be in good condition too https://fix-product-type-attributes-empty-table.dashboard.saleor.rocks/storybook/index.html?path=/story/views-product-types-product-type-details--no-attributes |
passed to QA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested positive on deployed environment and checked storybook
I want to merge this change because... it displays just no attributes found message without table header when there are no attributes to display in the table.
PR intended to be tested with API branch:
Screenshots
Pull Request Checklist
Test environment config
API_URI=https://master.staging.saleor.rocks/graphql/