Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style of product type attributes empty table #744

Merged
merged 2 commits into from Oct 7, 2020

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Oct 2, 2020

I want to merge this change because... it displays just no attributes found message without table header when there are no attributes to display in the table.

PR intended to be tested with API branch:

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to fix-product-type-attributes-empty-table October 2, 2020 10:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook fix-product-type-attributes-empty-table October 2, 2020 10:41 Inactive
@patrys
Copy link
Member

patrys commented Oct 2, 2020

Copy link
Member

@krzysztofwolski krzysztofwolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orzechdev
Copy link
Contributor Author

passed to QA

@mlamperski mlamperski self-requested a review October 7, 2020 11:22
Copy link

@mlamperski mlamperski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested positive on deployed environment and checked storybook

@orzechdev orzechdev merged commit 758c227 into master Oct 7, 2020
@orzechdev orzechdev deleted the fix/product-type-attributes-empty-table branch October 7, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants