Structure overhaul #1187
Structure overhaul #1187
Conversation
patrys
commented
Jun 18, 2024
patrys
commented
- Split documentation into several pages with separate sidebars
- Unified the structure somewhat
- Removed what looks like accidental commits to the API reference
- Got rid of some complex custom sidebar formatting
- Dropped giscus and "was this page helpful?"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/css/components/menu.css
Outdated
| @@ -15,28 +15,10 @@ | |||
|
|
|||
| .menu__link { | |||
| font-size: var(--font-size-sm); | |||
| color: var(--gray10); | |||
| transition: all 0.3s ease-in-out; | |||
There was a problem hiding this comment.
suggestion:
(I hope this is the right place)
IMO, we should decrease the duration of the transition. Moving cursor from top of the sidebar item list to the bottom leaves a background color "smudge" for too long (to my taste).
Nagranie.z.ekranu.2024-06-19.o.12.41.16.mov
There was a problem hiding this comment.
This is completely unrelated to this PR, though. I only reverted even uglier sidebar styling to its original state.
There was a problem hiding this comment.
I disagree it's unrelated. You changed the way the sidebar looks and I was just sharing my opinion that this particular bit, to me, now looks off.
There was a problem hiding this comment.
I removed all easing from the sidebar, so the animation is gone entirely.
You are welcome to write something there. I wanted to have a predictable link target but I don't have the time to create new content.
That's intentional. The same is true for all the other links from the top nav as they are merely shortcuts. |
|
I think "Extending Saleor" belongs to core concept |
|
About Saleor can not be collapsed as Why saleor |
I wanted "core concepts" to be about using Saleor, not building stuff around it. You are welcome to propose a better name for the section. Medusa calls a similar thing "Commerce Modules." |
- Split documentation into several pages with separate sidebars - Unified the structure somewhat - Removed what looks like accidental commits to the API reference - Got rid of some complex custom sidebar formatting - Dropped giscus and "was this page helpful?"
|
@aniav we can merge now? |
|
@timuric had to do path tweaks, once vercel builds I will merge to not block anything any more 🙌 |
