Skip to content

Commit

Permalink
Improve labels
Browse files Browse the repository at this point in the history
  • Loading branch information
dominik-zeglen committed Oct 12, 2018
1 parent a6e1796 commit 258362e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ const SiteSettingsDetails: React.StatelessComponent<
error={!!errors.name}
fullWidth
name="name"
label={i18n.t("Name of your store", {
context: "field label"
})}
label={i18n.t("Name of your store")}
helperText={
errors.name ||
i18n.t("Name of your store is shown on tab in web browser")
Expand All @@ -50,10 +48,8 @@ const SiteSettingsDetails: React.StatelessComponent<
error={!!errors.domain}
fullWidth
name="domain"
label={i18n.t("Domain", {
context: "field label"
})}
helperText={errors.domain || i18n.t("Domain is your store URL")}
label={i18n.t("URL of your online store")}
helperText={errors.domain}
value={data.domain}
onChange={onChange}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40732,7 +40732,7 @@ exports[`Storyshots Views / Site settings / Page default 1`] = `
class="MuiFormLabel-root-id MuiFormLabel-filled-id MuiInputLabel-root-id MuiInputLabel-formControl-id MuiInputLabel-animated-id MuiInputLabel-shrink-id"
data-shrink="true"
>
Domain
URL of your online store
</label>
<div
class="MuiInput-root-id MuiInput-fullWidth-id MuiInput-formControl-id MuiInput-underline-id"
Expand All @@ -40745,11 +40745,6 @@ exports[`Storyshots Views / Site settings / Page default 1`] = `
value="localhost:8000"
/>
</div>
<p
class="MuiFormHelperText-root-id MuiFormHelperText-filled-id"
>
Domain is your store URL
</p>
</div>
<div
class="Component-spacer-id"
Expand Down Expand Up @@ -41025,7 +41020,7 @@ exports[`Storyshots Views / Site settings / Page form errors 1`] = `
class="MuiFormLabel-root-id MuiFormLabel-error-id MuiFormLabel-filled-id MuiInputLabel-root-id MuiInputLabel-formControl-id MuiInputLabel-animated-id MuiInputLabel-shrink-id"
data-shrink="true"
>
Domain
URL of your online store
</label>
<div
class="MuiInput-root-id MuiInput-error-id MuiInput-fullWidth-id MuiInput-formControl-id MuiInput-underline-id"
Expand Down Expand Up @@ -41319,7 +41314,7 @@ exports[`Storyshots Views / Site settings / Page loading 1`] = `
class="MuiFormLabel-root-id MuiInputLabel-root-id MuiInputLabel-formControl-id MuiInputLabel-animated-id"
data-shrink="false"
>
Domain
URL of your online store
</label>
<div
class="MuiInput-root-id MuiInput-disabled-id MuiInput-fullWidth-id MuiInput-formControl-id MuiInput-underline-id"
Expand All @@ -41333,11 +41328,6 @@ exports[`Storyshots Views / Site settings / Page loading 1`] = `
value=""
/>
</div>
<p
class="MuiFormHelperText-root-id"
>
Domain is your store URL
</p>
</div>
<div
class="Component-spacer-id"
Expand Down

0 comments on commit 258362e

Please sign in to comment.