Merge pull request #6092 from mirumee/handle-none-as-attribute-value

Handle None as attribute value

CHANGELOG.md

@@ -45,6 +45,7 @@ All notable, unreleased changes to this project will be documented in this file.
 - Fix incorrect calculation of subtotal with active Avatax - #6035 by @korycins
 - Fix incorrect assigment of tax_code for Avatax - #6035 by @korycins
 - Do not allow negative product price - #6091 by @IKarbowiak
+- Handle None as attribute value - #6092 by @IKarbowiak
 
 ## 2.10.2
 

saleor/graphql/product/tests/test_variant.py

@@ -819,6 +819,7 @@ def test_update_product_variant_with_duplicated_attribute(
         ([], "size expects a value but none were given"),
         (["one", "two"], "A variant attribute cannot take more than one value"),
         (["   "], "Attribute values cannot be blank"),
+        ([None], "Attribute values cannot be blank"),
     ),
 )
 def test_update_product_variant_requires_values(
@@ -828,6 +829,7 @@ def test_update_product_variant_requires_values(
 
     - No values
     - Blank value
+    - None as value
     - More than one value
     """
 

saleor/graphql/product/utils.py

@@ -50,7 +50,7 @@ def validate_attribute_input_for_variant(instance: "Attribute", values: List[str
             code=ProductErrorCode.INVALID.value,
         )
 
-    if not values[0].strip():
+    if values[0] is None or not values[0].strip():
         raise ValidationError(
             "Attribute values cannot be blank", code=ProductErrorCode.REQUIRED.value
         )