Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProductImage GraphQL type should contain alt_text #3257

Closed
Pacu2 opened this issue Nov 8, 2018 · 1 comment · Fixed by #3429
Closed

ProductImage GraphQL type should contain alt_text #3257

Pacu2 opened this issue Nov 8, 2018 · 1 comment · Fixed by #3429
Assignees
@fowczarek
Labels
graphql Issues related to the GraphQL API in progress
Projects
GraphQL API
Milestone
Week 50

Comments

@Pacu2
Copy link
Contributor

Pacu2 commented Nov 8, 2018

We should expose the alt (text) on ProductImage type and all relevant types (eg. Product contains thumbnail_url).

All images on the storefront should contain an alt text for accessibility & SEO reasons.
@Pacu2 Pacu2 added the graphql Issues related to the GraphQL API label Nov 8, 2018
@Pacu2 Pacu2 added this to To do in GraphQL API via automation Nov 8, 2018
@maarcingebala maarcingebala added this to the Week 50 milestone Dec 5, 2018
@fowczarek fowczarek self-assigned this Dec 10, 2018
@maarcingebala
Copy link
Member

  • update thumbnailUrl field to use ProductImage type
  • add background_image_alt text field to Collection and Category models and expose it in API (queries and mutations)
  • add alt text field in the Image type

@fowczarek fowczarek mentioned this issue Dec 11, 2018
Merged
18 tasks
GraphQL API automation moved this from To do to Done Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fowczarek fowczarek

Labels
graphql Issues related to the GraphQL API in progress
Projects
No open projects
GraphQL API
  
Done
Milestone
Week 50
Development

Successfully merging a pull request may close this issue.

Add alt text to Product thumbnail and background_image of Collection and Category saleor/saleor
3 participants
@maarcingebala @Pacu2 @fowczarek