New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alt text to Product thumbnail and background_image of Collection and Category #3429
Conversation
8223834
to
a9e2068
Compare
4980ecf
to
fd5b926
Compare
Product
thumbnail
and background_image
of Collection and Category
Product
thumbnail
and background_image
of Collection and Categoryfd5b926
to
9da18ea
Compare
Codecov Report
@@ Coverage Diff @@
## master #3429 +/- ##
==========================================
+ Coverage 89.73% 89.74% +<.01%
==========================================
Files 237 237
Lines 12912 12925 +13
Branches 1308 1304 -4
==========================================
+ Hits 11587 11599 +12
Misses 921 921
- Partials 404 405 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3429 +/- ##
=========================================
Coverage ? 89.76%
=========================================
Files ? 237
Lines ? 12938
Branches ? 1312
=========================================
Hits ? 11614
Misses ? 920
Partials ? 404
Continue to review full report at Codecov.
|
I want to merge this change because resolve #3257
To do:
alt' text filed in the
Image` typebackground_image_alt
toCollection
modelbackground_image_alt
toCollection
in APIbackground_image_alt
ofCollection
in dashboardbackground_image_alt
ofCollection
in dashboard2.0background_image_alt
toCategory
modelbackground_image_alt
toCategory
in APIbackground_image_alt
ofCategory
in dashboardbackground_image_alt
ofCategory
in dashboard2.0thumbnail_url
field to useProductImage
typePull Request Checklist