-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Sorting warehouses within channel #10416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowczarek
approved these changes
Aug 18, 2022
IKarbowiak
changed the title
[RFC] Sorting warehouses within shipping zone
[RFC] Sorting warehouses within channel
Aug 19, 2022
IKarbowiak
force-pushed
the
sorting-warehouses-within-shipping-zone
branch
from
August 21, 2022 09:32
f429822
to
c1dd989
Compare
IKarbowiak
force-pushed
the
sorting-warehouses-within-shipping-zone
branch
from
August 22, 2022 07:12
c1dd989
to
b83cd16
Compare
fowczarek
approved these changes
Aug 22, 2022
…ehouses-within-channel Add mutation for reordering warehouses within channel
Handle allocation strategies
Rename allocationSettings to stockSettings
github-actions
bot
temporarily deployed
to
sorting-warehouses-within-shipping-zone
August 24, 2022 06:03
Inactive
IKarbowiak
added
test deployment
Deploy test environment for pull request
and removed
test deployment
Deploy test environment for pull request
labels
Aug 24, 2022
github-actions
bot
temporarily deployed
to
sorting-warehouses-within-shipping-zone
August 24, 2022 09:48
Inactive
5 tasks
timuric
approved these changes
Aug 25, 2022
maarcingebala
approved these changes
Aug 25, 2022
github-actions
bot
temporarily deployed
to
sorting-warehouses-within-shipping-zone
August 26, 2022 06:58
Inactive
github-actions
bot
temporarily deployed
to
sorting-warehouses-within-shipping-zone
August 26, 2022 07:03
Inactive
github-actions
bot
temporarily deployed
to
sorting-warehouses-within-shipping-zone
August 26, 2022 11:17
Inactive
fowczarek
approved these changes
Aug 26, 2022
jakubkuc
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rfc
Request For Comments: blueprints of upcoming changes.
test deployment
Deploy test environment for pull request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to allow staff users to set the warehouse order of stock allocation and reservation. The warehouse order will be configurable per channel
General assumptions
MANAGE_CHANNELS
permission should be able to sort the warehouses within the channel.PRIORITIZE_SORTING_ORDER
will be set.PRIORITIZE_HIGH_STOCK
.Allocation and reservations
PRIORITIZE_SORTING_ORDER
strategy)PRIORITIZE_HIGH_STOCK
strategy)The example of stocks and allocations for:
PRIORITIZE_SORTING_ORDER
strategyPRIORITIZE_HIGH_STOCK
strategyDatabase changes
Rewrite the
Channel - Warehouse
intermediate model. Extend it with thesort_order
field.Tips:
Extend the
Channel
model withallocation_strategy: CharField
field with the choices:follow_the_warehouse_order
,prioritize_high_stock
.API changes
Introduce
StockSettings
type.Extend the
channel
type withallocationSettings
field. Allow defining theallocationSettings
in thechannelCreate
andchannelUpdate
mutations.Add a
channelReorderWarehouses
mutation for sorting the warehouses assigned to the channel.Internal task: SALEOR-7914
Impact
Pull Request Checklist