Drop django rest framework usage #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please regenerate the requirements file using Python 3 😄 |
mad-anne
force-pushed
the
drop-drf
branch
2 times, most recently
from
c129b71
to
0ef0a5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
+ Coverage 68.51% 68.63% +0.11%
==========================================
Files 114 113 -1
Lines 6133 6140 +7
Branches 747 751 +4
==========================================
+ Hits 4202 4214 +12
+ Misses 1760 1754 -6
- Partials 171 172 +1
Continue to review full report at Codecov.
|
saleor/dashboard/product/views.py
Outdated
| @staff_member_required | ||
| def ajax_reorder_product_images(request, product_pk): | ||
| product = get_object_or_404(Product, pk=product_pk) | ||
| data = json.loads(request.body) |
There was a problem hiding this comment.
I think we could use custom form that would accept one field with comma separated integers. Then you could move this whole logic there and keep the view simple.
maarcingebala
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1119