Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename items to lines #1414

Merged
merged 2 commits into from
Dec 5, 2017
Merged

Rename items to lines #1414

merged 2 commits into from
Dec 5, 2017

Conversation

akjanik
Copy link
Contributor

@akjanik akjanik commented Dec 4, 2017

I want to merge this change because...

Fixes #1388

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. The changes are tested.
  6. The code is documented (docstrings, project documentation).
  7. Python code quality checks pass: pycodestyle, pydocstyle, pylint.
  8. JavaScript code quality checks pass: eslint.

@akjanik akjanik added this to the 2017.12 milestone Dec 4, 2017
@akjanik akjanik self-assigned this Dec 4, 2017
@codecov-io
Copy link

codecov-io commented Dec 4, 2017

Codecov Report

Merging #1414 into master will increase coverage by 0.23%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
+ Coverage    82.9%   83.14%   +0.23%     
==========================================
  Files         128      129       +1     
  Lines        5775     5855      +80     
  Branches      663      665       +2     
==========================================
+ Hits         4788     4868      +80     
- Misses        830      831       +1     
+ Partials      157      156       -1
Impacted Files Coverage Δ
saleor/dashboard/order/utils.py 100% <ø> (ø) ⬆️
saleor/userprofile/views.py 36.11% <ø> (ø) ⬆️
saleor/dashboard/order/views.py 56.95% <ø> (ø) ⬆️
saleor/dashboard/views.py 53.12% <ø> (ø) ⬆️
saleor/dashboard/order/forms.py 73.39% <0%> (ø) ⬆️
saleor/order/models.py 88.62% <100%> (-0.4%) ⬇️
saleor/dashboard/customer/filters.py 100% <0%> (ø) ⬆️
saleor/dashboard/shipping/filters.py 100% <0%> (ø) ⬆️
saleor/dashboard/group/filters.py 100% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eceaa1...f3d4264. Read the comment docs.

@dominik-zeglen dominik-zeglen changed the title 1388 rename items to lines Rename items to lines Dec 5, 2017
@maarcingebala maarcingebala merged commit aa33fa5 into master Dec 5, 2017
@maarcingebala maarcingebala deleted the 1388_rename_items_to_lines branch May 25, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants