-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify button style #1419
Unify button style #1419
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1419 +/- ##
=======================================
Coverage 83.41% 83.41%
=======================================
Files 128 128
Lines 5795 5795
Branches 665 665
=======================================
Hits 4834 4834
Misses 803 803
Partials 158 158 Continue to review full report at Codecov.
|
This is not consistent with how Google uses material design. IMHO we should not be giving flat buttons a background at all (that's why they are flat). Why not increase the contrast of the text color instead? |
Background appears only when button is focused - in its "idle" state it's really flat. Like 100% Material Design specification flat. Also, I followed guide lines from here: |
Sorry, I thought you made the background grey on hover, not on focus. |
&:hover { | ||
background: $error-color; | ||
color: #fff; | ||
background: transparentize(#cccccc, .6); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, you do set background color on hover. This should be :focus
, :active
below is correct.
230d939
to
d8be77a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've now changed :active and :focus to be identical but they're not supposed to be per spec.
Is there a color change on :hover for flat buttons?
No, reverted that. Also you are right, we should set in css only :focus, press effect is done by JS. |
This PR unifies button style in dashboard. Changes flat button's background to gray (when focused), so it doesn't look like primary button when hovered over. Also applies minor hotfixes to UI.