-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade GraphQL stack #1423
Upgrade GraphQL stack #1423
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1423 +/- ##
==========================================
- Coverage 82.44% 82.43% -0.01%
==========================================
Files 131 131
Lines 5668 5665 -3
Branches 647 647
==========================================
- Hits 4673 4670 -3
Misses 831 831
Partials 164 164
Continue to review full report at Codecov.
|
saleor/graphql/api.py
Outdated
price_lte = args.get('price_lte') | ||
price_gte = args.get('price_gte') | ||
tree = self.get_descendants(include_self=True) | ||
qs = qs.filter(categories__in=tree) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That distinct()
was here to return proper results when there are multiple categories of the same name (this was added in PR #1331).
e266b79
to
6325f4a
Compare
Closes #1330
This PR also changes the behavior of
resolve_products
resolver. This function used to return products belonging to the given category and its descendants. This PR changes it not to include products from the descendant categories. This is consistent with the behavior of category index view in the storefront.Pull Request Checklist
pycodestyle
,pydocstyle
,pylint
.eslint
.