Opengraph, canonical URLs, 'next' and 'prev' #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrys
reviewed
Dec 7, 2017
templates/category/index.html
Outdated
| <meta property="og:description" content="{{ category.description }}"> | ||
| <meta property="og:image" content="{% static "images/block1.png" %}"> | ||
|
|
||
| {% with category_url=category.get_full_absolute_url %} |
There was a problem hiding this comment.
You have access to request here which can convert relative URLs to absolute ones, you don't need category.get_full_absolute_url.
patrys
reviewed
Dec 7, 2017
saleor/product/models.py
Outdated
| def get_full_absolute_url(self, ancestors=None): | ||
| return build_absolute_uri( | ||
| self.get_absolute_url(ancestors=ancestors) | ||
| ) |
There was a problem hiding this comment.
Pretty pleeeeeease with a cherry on top: don't leave hanging parenthesis, brackets or braces.
Pacu2
force-pushed
the
feature/opengraph-and-canonical
branch
from
f07490f
to
14e5d7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1448 +/- ##
==========================================
+ Coverage 82.44% 83.54% +1.09%
==========================================
Files 131 128 -3
Lines 5668 5784 +116
Branches 647 662 +15
==========================================
+ Hits 4673 4832 +159
+ Misses 831 794 -37
+ Partials 164 158 -6
Continue to review full report at Codecov.
|
Closed
Pacu2
force-pushed
the
feature/opengraph-and-canonical
branch
from
d66947a
to
5199b1b
Compare
maarcingebala
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1403
Close #1345
canonicalforProductandCategorypagesnextandprevtags forCategoryandSearchpagesTODO:
nextandprevtags forCategorypageog:urllinks absolute