Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove order status field #1481

Merged
merged 22 commits into from
Dec 18, 2017
Merged

Conversation

mad-anne
Copy link
Contributor

@mad-anne mad-anne commented Dec 14, 2017

This changes remove status field form Order and make it deduced based on related Delivery Groups statuses.

Closes #1475

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. The changes are tested.
  6. The code is documented (docstrings, project documentation).
  7. Python code quality checks pass: pycodestyle, pydocstyle, pylint.
  8. JavaScript code quality checks pass: eslint.

@mad-anne mad-anne self-assigned this Dec 14, 2017
@codecov-io
Copy link

codecov-io commented Dec 14, 2017

Codecov Report

Merging #1481 into master will increase coverage by 0.16%.
The diff coverage is 80.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
+ Coverage   82.44%   82.61%   +0.16%     
==========================================
  Files         131      131              
  Lines        5668     5677       +9     
  Branches      647      648       +1     
==========================================
+ Hits         4673     4690      +17     
+ Misses        831      823       -8     
  Partials      164      164
Impacted Files Coverage Δ
saleor/order/signals.py 0% <ø> (ø) ⬆️
saleor/search/backends/elasticsearch_dashboard.py 100% <ø> (ø) ⬆️
saleor/checkout/views/summary.py 44.82% <ø> (ø) ⬆️
saleor/dashboard/views.py 51.61% <0%> (ø) ⬆️
saleor/dashboard/order/views.py 56.67% <100%> (ø) ⬆️
saleor/search/documents.py 78% <100%> (ø) ⬆️
saleor/dashboard/product/views.py 70.1% <100%> (+0.07%) ⬆️
saleor/order/models.py 88.46% <100%> (+0.58%) ⬆️
saleor/core/templatetags/status.py 51.51% <100%> (ø) ⬆️
saleor/dashboard/order/forms.py 74.64% <42.85%> (+2.04%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e7f8b...ba3dc30. Read the comment docs.

@maarcingebala maarcingebala merged commit 23bf470 into saleor:master Dec 18, 2017
@mad-anne mad-anne deleted the remove-order-status branch January 8, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants